Spaces:
Running
on
CPU Upgrade
Running
on
CPU Upgrade
Minimal edit for directory structure assumption.
#11
by
meg
HF staff
- opened
The code appears to assume a certain directory structure, where only files (not another directory) will be found.
Suggesting adding a check so that only files will be retrieved.
However, I would write this function differently in a few ways -- do let me know if you'd prefer a larger suggestion on this!
Merging this one for now, but a larger edit is completely doable.
I also realized that having requests and results follow the same pattern might be easier for most users too (org/model/request_precision) (org/model/result_datetime) instead of org/model/result.json and org/model_eval_request_..._precision_....json. Feel free to tell me what you have in mind! :)
clefourrier
changed pull request status to
merged