google/quickdraw · Remove deprecated tasks

Aug 25

This dataset uses tasks, which are deprecated and will raise an error after the next major release of datasets. See: https://github.com/huggingface/datasets/pull/6999

Remove deprecated tasks65ddac35

albertvillanova changed pull request status to merged Aug 25

darknoon

Aug 27

Hey, I think this commit broke loading the dataset!
I think we need to remove the trailing comma on this: citation=_CITATION,

        return datasets.DatasetInfo(
            description=_DESCRIPTION,
            features=features,
            homepage=_HOMEPAGE,
            license=_LICENSE,
            citation=_CITATION,
            if self.config.name == "preprocessed_bitmaps"
            else None,
        )

I'm able to reproduce like so:

(whale) ~/Developer/whale (main u=) $ python
Python 3.11.9 (main, Apr 19 2024, 16:48:06) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from datasets import load_dataset
>>> load_dataset("google/quickdraw", "sketch_rnn", trust_remote_code=True)
Downloading builder script: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████| 14.6k/14.6k [00:00<00:00, 85.1MB/s]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/andrew/miniconda3/envs/whale/lib/python3.11/site-packages/datasets/load.py", line 2594, in load_dataset
    builder_instance = load_dataset_builder(
                       ^^^^^^^^^^^^^^^^^^^^^
  File "/home/andrew/miniconda3/envs/whale/lib/python3.11/site-packages/datasets/load.py", line 2301, in load_dataset_builder
    builder_cls = get_dataset_builder_class(dataset_module, dataset_name=dataset_name)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/andrew/miniconda3/envs/whale/lib/python3.11/site-packages/datasets/load.py", line 252, in get_dataset_builder_class
    builder_cls = import_main_class(dataset_module.module_path)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/andrew/miniconda3/envs/whale/lib/python3.11/site-packages/datasets/load.py", line 167, in import_main_class
    module = importlib.import_module(module_path)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/andrew/miniconda3/envs/whale/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 936, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1074, in get_code
  File "<frozen importlib._bootstrap_external>", line 1004, in source_to_code
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/andrew/.cache/huggingface/modules/datasets_modules/datasets/google--quickdraw/8674923df3490f73f6f5bb96947692b5272b861838228ed28dd4ddd8de9e9129/quickdraw.py", line 237
    if self.config.name == "preprocessed_bitmaps"
    ^^
SyntaxError: invalid syntax

albertvillanova

Aug 27

Thanks for reporting @darknoon .

I am sorry I made a bad manipulation in https://huggingface.co/datasets/google/quickdraw/discussions/5/files

I am fixing it.

albertvillanova

Aug 27

Fixed by #6.