jbilcke-hf HF staff commited on
Commit
b1fd525
β€’
1 Parent(s): ba0236b

disable bad rendering

Browse files
src/app/engine/render.ts CHANGED
@@ -359,31 +359,7 @@ export async function newRender({
359
  segments: []
360
  } as RenderedScene
361
  } else {
362
- /*
363
- console.log("sending:", {
364
- prompt,
365
- // negativePrompt, unused for now
366
- nbFrames: 1,
367
- nbSteps: nbInferenceSteps, // 20 = fast, 30 = better, 50 = best
368
- actionnables: [], // ["text block"],
369
- segmentation: "disabled", // "firstframe", // one day we will remove this param, to make it automatic
370
- width,
371
- height,
372
-
373
- // no need to upscale right now as we generate tiny panels
374
- // maybe later we can provide an "export" button to PDF
375
- // unfortunately there are too many requests for upscaling,
376
- // the server is always down
377
- upscalingFactor: 1, // 2,
378
-
379
- turbo: settings.renderingUseTurbo,
380
-
381
- // analyzing doesn't work yet, it seems..
382
- analyze: false, // analyze: true,
383
-
384
- cache: "ignore"
385
- })
386
- */
387
  const res = await fetch(`${videochainApiUrl}${videochainApiUrl.endsWith("/") ? "" : "/"}render`, {
388
  method: "POST",
389
  headers: {
@@ -409,7 +385,9 @@ export async function newRender({
409
  // the server is always down
410
  upscalingFactor: 1, // 2,
411
 
412
- turbo: settings.renderingUseTurbo,
 
 
413
 
414
  // analyzing doesn't work yet, it seems..
415
  analyze: false, // analyze: true,
 
359
  segments: []
360
  } as RenderedScene
361
  } else {
362
+
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
363
  const res = await fetch(`${videochainApiUrl}${videochainApiUrl.endsWith("/") ? "" : "/"}render`, {
364
  method: "POST",
365
  headers: {
 
385
  // the server is always down
386
  upscalingFactor: 1, // 2,
387
 
388
+ // let's completely disable turbo mode, it doesn't work well for drawings and comics,
389
+ // basically all the people I talked to said it sucked
390
+ turbo: false, // settings.renderingUseTurbo,
391
 
392
  // analyzing doesn't work yet, it seems..
393
  analyze: false, // analyze: true,
src/app/interface/settings-dialog/index.tsx CHANGED
@@ -77,14 +77,14 @@ export function SettingsDialog() {
77
  <DialogTrigger asChild>
78
  <Button className="space-x-1 md:space-x-2">
79
  <div>
80
- <span className="hidden md:inline">Improve quality</span>
81
  </div>
82
  </Button>
83
  </DialogTrigger>
84
  <DialogContent className="w-full sm:max-w-[500px] md:max-w-[700px] overflow-y-auto h-max-[100vh] md:h-max-[80vh]">
85
  <DialogHeader>
86
  <DialogDescription className="w-full text-center text-lg font-bold text-stone-800">
87
- Custom Settings
88
  </DialogDescription>
89
  </DialogHeader>
90
  <div className="grid gap-4 py-1 space-y-1 text-stone-800">
@@ -92,10 +92,10 @@ export function SettingsDialog() {
92
  Note: most vendors have a warm-up delay when using a custom or rarely used model. Do not hesitate to try again after 5 minutes if that happens.
93
  </p>
94
  <p className="text-sm text-zinc-700">
95
- Security note: we do not save those settings on our side, instead they are stored inside your web browser, using the local storage.
96
  </p>
97
  <Field>
98
- <Label>Image vendor:</Label>
99
  <Select
100
  onValueChange={(value: string) => {
101
  setRenderingModelVendor(value as RenderingModelVendor)
@@ -112,18 +112,30 @@ export function SettingsDialog() {
112
  </SelectContent>
113
  </Select>
114
  </Field>
115
-
116
- {renderingModelVendor === "SERVER" && <>
 
 
117
  <Field>
118
- <Label>Quality over performance ratio:</Label>
119
  <div className="flex flex-row space-x-2 text-zinc-500">
120
  <Switch
121
- checked={renderingUseTurbo}
122
- onCheckedChange={setRenderingUseTurbo}
 
 
 
123
  />
 
124
  <span
125
  onClick={() => setRenderingUseTurbo(!renderingUseTurbo)}
126
- className={cn("cursor-pointer", { "text-zinc-800": renderingUseTurbo })}>Use a faster, but lower quality model (you are warned!)</span>
 
 
 
 
 
 
127
  </div>
128
  </Field>
129
  </>}
 
77
  <DialogTrigger asChild>
78
  <Button className="space-x-1 md:space-x-2">
79
  <div>
80
+ <span className="hidden md:inline">Custom models</span>
81
  </div>
82
  </Button>
83
  </DialogTrigger>
84
  <DialogContent className="w-full sm:max-w-[500px] md:max-w-[700px] overflow-y-auto h-max-[100vh] md:h-max-[80vh]">
85
  <DialogHeader>
86
  <DialogDescription className="w-full text-center text-lg font-bold text-stone-800">
87
+ Custom Models
88
  </DialogDescription>
89
  </DialogHeader>
90
  <div className="grid gap-4 py-1 space-y-1 text-stone-800">
 
92
  Note: most vendors have a warm-up delay when using a custom or rarely used model. Do not hesitate to try again after 5 minutes if that happens.
93
  </p>
94
  <p className="text-sm text-zinc-700">
95
+ Security note: we do not save your API credentials on our server but inside your web browser, using the local storage.
96
  </p>
97
  <Field>
98
+ <Label>Image rendering provider:</Label>
99
  <Select
100
  onValueChange={(value: string) => {
101
  setRenderingModelVendor(value as RenderingModelVendor)
 
112
  </SelectContent>
113
  </Select>
114
  </Field>
115
+
116
+
117
+ {
118
+ renderingModelVendor === "SERVER" && <>
119
  <Field>
120
+ <Label>Quality over performance ratio (beta, deprecated):</Label>
121
  <div className="flex flex-row space-x-2 text-zinc-500">
122
  <Switch
123
+ // checked={renderingUseTurbo}
124
+ // onCheckedChange={setRenderingUseTurbo}
125
+ checked={false}
126
+ disabled
127
+ className="opacity-30 pointer-events-none"
128
  />
129
+ {/*
130
  <span
131
  onClick={() => setRenderingUseTurbo(!renderingUseTurbo)}
132
+ className={cn("cursor-pointer", { "text-zinc-800": renderingUseTurbo })}>
133
+ Use a faster, but lower quality model (you are warned!)
134
+ </span>
135
+ */}
136
+ <span className="text-zinc-500 italic">
137
+ Following feedbacks from users (low rendering quality on comics) the fast renderer has been disabled.
138
+ </span>
139
  </div>
140
  </Field>
141
  </>}